Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore `.yalc/` folder when we publish to npm #203

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
3 participants
@dsmilkov
Copy link
Member

commented May 4, 2019

Add .yalc to .npmignore and update the version of coco-ssd so we can republish.

We published coco-ssd with .yalc which contains node_modules, making the package size exceed 50mb. This results in jsdelivr failing to serve our bundles with the error Package size exceeded the configured limit of 50 MB.
: https://cdn.jsdelivr.net/npm/@tensorflow-models/coco-ssd

I verified that all the other models are working.


This change is Reviewable

@dsmilkov dsmilkov requested review from tafsiri and nsthorat May 4, 2019

@googlebot googlebot added the cla: yes label May 4, 2019

@nsthorat
Copy link
Collaborator

left a comment

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat and @tafsiri)

@dsmilkov dsmilkov merged commit ea31fc1 into master May 13, 2019

2 checks passed

Trigger: 4a365406-6c43-48f6-8c37-06ef741fbf9d Summary
Details
cla/google All necessary CLAs are signed

@dsmilkov dsmilkov deleted the ignore-yalc branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.