Skip to content
This repository was archived by the owner on Sep 17, 2022. It is now read-only.

Conversation

kangyizhang
Copy link

@kangyizhang kangyizhang commented Aug 5, 2019

This change is Reviewable

Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @kangyizhang)


package.json, line 69 at r1 (raw file):

      4
    ],
    "package_name": "CPU-darwin-1.2.6.tar.gz"

is this intended? also did this happen automatically from the release script?

Copy link
Author

@kangyizhang kangyizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat)


package.json, line 69 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

is this intended? also did this happen automatically from the release script?

Yes. It's automatically edited when installing node native addon. It won't affect anything but quite confusing for ourselves. I have filed tensorflow/tfjs#1756 to track

Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)

@kangyizhang kangyizhang merged commit 53454cb into master Aug 5, 2019
@kangyizhang kangyizhang deleted the b1.2.6 branch August 5, 2019 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants