Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of constructor.name in optimizers.ts #82

Closed
nsthorat opened this issue Apr 3, 2018 · 0 comments · Fixed by tensorflow/tfjs-layers#108
Closed

Remove usage of constructor.name in optimizers.ts #82

nsthorat opened this issue Apr 3, 2018 · 0 comments · Fixed by tensorflow/tfjs-layers#108
Assignees
@nsthorat
Labels
comp:layers

Comments

@nsthorat
Copy link
Contributor

nsthorat commented Apr 3, 2018

TensorFlow.js version

0.6.1 - using minified bundle

Describe the problem or feature request

We are using constructor.name here which gets minified when using the standalone bundle:
https://github.com/tensorflow/tfjs-layers/blob/8e8b1a3265440573950ef5c1e41c2efd9a6a6a47/src/optimizers.ts#L466

Then it throws an error :)

Code to reproduce the bug / link to feature request

  const optimizer = tf.train.adam(0.0001);
  
  model.compile({optimizer, loss: 'categoricalCrossentropy'});
@nsthorat nsthorat self-assigned this Apr 3, 2018
@nsthorat nsthorat mentioned this issue Apr 3, 2018
Merged
nsthorat pushed a commit to tensorflow/tfjs-layers that referenced this issue Apr 3, 2018
Remove LayersOptimizers. (#108)
db5081c 
This PR removes LayersOptimizers.

We will push serialization logic down into core optimizers (getConfig and fromConfig). Now, we allow any subclass of `tf.Optimizer` to be passed and we don't whitelist the core optimizers by constructor name (which causes problems with bundlizing).

This fixes tensorflow/tfjs#82
easadler pushed a commit to easadler/tfjs that referenced this issue Apr 12, 2018
@Lewuathe
Make sure to launch http server after initial bundle (tensorflow#82)
a846c52 
* Make sure to launch http server after initial bundle

Since demo code depends on the bundle.js, http server should be launched
just after initial bundle creation.
nsthorat pushed a commit that referenced this issue Aug 19, 2019
@nkreeger
Change API registration. (#82)
ec46e0e
nsthorat pushed a commit that referenced this issue Aug 20, 2019
@dependabot @tafsiri
Bump lodash from 4.17.11 to 4.17.14 in /demos/api (#82)
dd0e07d
@jimlloyd jimlloyd mentioned this issue Jun 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsthorat nsthorat

Labels
comp:layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove LayersOptimizers. tensorflow/tfjs-layers
1 participant
@nsthorat