Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize depthwise conv ops. #4078

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Oct 16, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @jinjingforever, @lina128, and @tafsiri)


tfjs-core/src/ops/depthwise_conv2d_native_backprop_filter.ts, line 29 at r1 (raw file):

function depthwiseConv2dNativeBackpropFilter_<T extends Tensor3D|Tensor4D>(
    x: T, dy: T, filterShape: [number, number, number, number],
    strides: [number, number]|number, pad: 'valid'|'same'|number,

+1. Good change.

Copy link
Collaborator

@jinjingforever jinjingforever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Na! LGTM

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @annxingyuan, @jinjingforever, and @lina128)


tfjs-backend-cpu/src/register_all_kernels.ts, line 138 at r1 (raw file):

  cosConfig,
  coshConfig,
  depthwiseConv2dNativeConfig,

nit: order

Copy link
Collaborator Author

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @tafsiri)


tfjs-backend-cpu/src/register_all_kernels.ts, line 138 at r1 (raw file):

Previously, jinjingforever (Jing Jin) wrote…

nit: order

Done.


tfjs-core/src/ops/depthwise_conv2d_native_backprop_filter.ts, line 29 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

+1. Good change.

Ack.

@lina128 lina128 merged commit 7603952 into tensorflow:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants