Don't rebuild core when running test-snippets in CI #4399
Conversation
There was a problem hiding this comment.
Thank you, looks like the other packages that contains snippet tests (layers, data, converter), do not have test-snippets-ci target, maybe keep consistent with those or update those to have ci suffix.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @pyu10055)
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)
tfjs-core/cloudbuild.yml, line 68 at r2 (raw file):
entrypoint: 'yarn' args: ['test-snippets-ci'] waitFor: ['yarn', 'build']
you might need to update the cloudbuild test golden file
There was a problem hiding this comment.
I'll update layers, data, and converter in this PR too. Commits coming in a moment.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
tfjs-core/cloudbuild.yml, line 68 at r2 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
you might need to update the cloudbuild test golden file
Yep, definitely. Nice catch!
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 7 of 7 files at r3.
Reviewable status:
Prevent test-snippets from rebuilding tfjs-core in CI and instead have it wait for core to be built by its own cloudbuild step.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is