Add shuffleCombo

[GantMan]

When shuffling an array of X and Y it's important that X still corresponds with Y.

This is a useful utility for shuffling training data that is in JavaScript form.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[GantMan]

@pyu10055 - I used this to shuffle X and Y in the same way.

[GantMan]

I'm having trouble seeing what is failing

[tafsiri]

@GantMan can you access https://pantheon.corp.google.com/cloud-build/builds/2030dc6f-f8da-4ac2-ad6c-c0ce5ce62c14?project=learnjs-174218

[GantMan]

No I cannot access pantheon bc I do not have a google.com email.

Also, the Details link lands me in Google Cloud Build, which shows this:

[tafsiri]

Wrt to the details link, it should give you access if you join one of the two mailing lists linked above (I can't remember if a google account is required but it might be). Are you already on one of those lists?

[GantMan]

@tafsiri - you rock. I missed that note, and now I can see the build issue. I'll dig into it.

[GantMan]

Thanks @tafsiri for getting me access to the logs. Sorry to bounce this back and forth so many times but I couldn't run the scripts on Windows, so I needed that access.

Should be good for eval now.

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @GantMan and @pyu10055)

---

tfjs-core/src/util_base.ts, line 72 at r4 (raw file):

// tslint:disable-next-line:no-any
                      array2: any[]|Uint32Array|Int32Array|Float32Array): void {
  console.assert(array.length === array2.length);

can you throw exception instead of using console.assert? TFJS support other platforms where console.assert might not be supported.

[GantMan]

@pyu10055 - good call, all fixed.

[GantMan]

Reviewed 1 of 1 files at r5.
Reviewable status: 0 of 1 approvals obtained (waiting on @GantMan)

[GantMan]

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

---

tfjs-core/src/util_base.ts, line 72 at r4 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

can you throw exception instead of using console.assert? TFJS support other platforms where console.assert might not be supported.

Done.

[GantMan]

@pyu10055 - anything else on this one?

[pyu10055]

Thanks Gant, can you add a unit test for this change?

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

[GantMan]

@pyu10055 - I noticed there was no test for util.shuffle either so I added a test for the existing shuffle and for my new shuffleCombo.

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

[GantMan]

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

[GantMan]

Reviewed 1 of 1 files at r6.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

[pyu10055]

thanks