Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeguard to initializer field. #4513

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Jan 9, 2021

TFX has some logic in exporter to remove some preprocessing nodes that are not included in the final graph, but collection_def still has table_initializer with an empty node list. Ideally, this should be fixed in the exporter code. Adding safeguard code on our side to only set modelInitializer field if node list is not empty.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Jan 9, 2021
@lina128 lina128 requested a review from pyu10055 January 9, 2021 01:14
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

@lina128 lina128 merged commit 9a364f1 into tensorflow:master Jan 9, 2021
@lina128 lina128 deleted the converter branch January 9, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants