Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak for complex tensors (#4563) #4564

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Jan 16, 2021

BUG

  • would work

  • ensure real and imag tensor would not get disposed if ref count > 0

  • fix typo

  • fixed engine refCount mismatch with webgl backend, fixed webgl simpleSlide that accidentally copied parent tensor refCount and parentRefCount;

  • add stft test to cpu

  • only reduce refCount if the tensor is part of complex tensor
    ;

Co-authored-by: Ann Yuan annyuan@gmail.com

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

BUG
* would work

* ensure real and imag tensor would not get disposed if ref count > 0

* fix typo

* fixed engine refCount mismatch with webgl backend, fixed webgl simpleSlide that accidentally copied parent tensor refCount and parentRefCount;

* add stft test to cpu

* only reduce refCount if the tensor is part of complex tensor
;

Co-authored-by: Ann Yuan <annyuan@gmail.com>
@pyu10055 pyu10055 requested a review from lina128 January 16, 2021 05:24
@google-cla
Copy link

google-cla bot commented Jan 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 16, 2021
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pyu10055 pyu10055 merged commit ea1c36d into base_2.8.x Jan 17, 2021
@pyu10055 pyu10055 deleted the 2.8_mem_inference branch January 17, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants