Skip to content

Conversation

OwenLiuzZ
Copy link
Collaborator

@OwenLiuzZ OwenLiuzZ commented Jun 13, 2018

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

@DEKHTIARJonathan
Copy link
Member

@OwenLiuzZ Thank you so much for your PR.

Please update the changelog with your contribution and add your name to the contributor list.
Please follow the formating

I let @zsdonghao reviewing your work ;)

@DEKHTIARJonathan DEKHTIARJonathan changed the title write for vgg19 pre-trained model and the example of this function tutorial [WIP] VGG19 Implementation with example Jun 13, 2018
@zsdonghao
Copy link
Member

@zsdonghao
Copy link
Member

A better coding style can be found here https://github.com/tensorlayer/tensorlayer/blob/master/tensorlayer/models/squeezenetv1.py, instead of using self.all_layers = net.xxxx, we set the model as Layer class.
Therefore, for other models, you can connect tfslim into the layer class.


raise Exception("unknown layer name (end_with): {}".format(end_with))

def restore_params(self, sess):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make it download automatically. @lgarithm @luomai any idea?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple solution is that we train all the models and store theses models in the libraryof the TL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a "This site can’t be reached" error when I tried to download the npy of VGG'19 from the website given.

How large is the npy file? Can we host it in our pre-trained model repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is about 570MB for this npy file. The public repo maximum limit for the file is 100 MB. However, I do not know what the limit is in the private repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original download link is for browser download only.
I've uploaded it to tensorlayer/pretrained-models, you can now use this download link in the program:

https://media.githubusercontent.com/media/tensorlayer/pretrained-models/master/models/vgg19.npy

@lgarithm
Copy link
Member

lgarithm commented Jun 14, 2018 via email

@lgarithm
Copy link
Member

@zsdonghao for vgg16 we used the pre-trained weights provided by http://www.cs.toronto.edu/~frossard/post/vgg16/.
But there is no corresponding weights for vgg19.
Where can we find a publicly available pre-trained vgg19 model for TF/TL?

@DEKHTIARJonathan
Copy link
Member

@OwenLiuzZ
Copy link
Collaborator Author

@lgarithm I use the pre-trained model from this repo

modify the change log and model API for PR698
@tensorlayer tensorlayer deleted a comment Jun 15, 2018
@tensorlayer tensorlayer deleted a comment Jun 15, 2018
@tensorlayer tensorlayer deleted a comment Jun 16, 2018
@tensorlayer tensorlayer deleted a comment Jun 16, 2018
@tensorlayer tensorlayer deleted a comment Jun 17, 2018
@tensorlayer tensorlayer deleted a comment Jun 17, 2018
@lgarithm
Copy link
Member

Hi, @OwenLiuzZ I've tested this PR on a clean VM, it works!
Please resolve conflicts and then it will be ready to merge.

@OwenLiuzZ
Copy link
Collaborator Author

Hi, @lgarithm I have resolve the conflicts. Thanks for reminding.

@zsdonghao zsdonghao changed the title [WIP] VGG19 Implementation with example VGG19 Implementation with example Jun 22, 2018
@zsdonghao zsdonghao merged commit f379918 into tensorlayer:master Jun 22, 2018
luomai pushed a commit that referenced this pull request Nov 21, 2018
* add vgg19 pre-trained model and the example of  tutorial

* modify the change log and model API for PR698

* add the function of automatically download the model in vgg19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants