Skip to content

matplotlib.use('TkAgg') #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2018
Merged

matplotlib.use('TkAgg') #705

merged 6 commits into from
Jun 17, 2018

Conversation

lgarithm
Copy link
Member

@lgarithm lgarithm commented Jun 17, 2018 •
edited
Loading

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

@luomai luomai self-requested a review June 17, 2018 07:35
luomai
luomai previously approved these changes Jun 17, 2018
View reviewed changes
@luomai luomai dismissed their stale review June 17, 2018 07:45

changelog

@DEKHTIARJonathan
Copy link
Member

Do you think you can add some code to only run this change under Mac OS?

I would prefer not having a bug fix which affects everyone if not necessary 😉

@DEKHTIARJonathan
Copy link
Member

@lgarithm I tried to use the sys package (already imported) instead of package, could you check it's still working ;)

Thanks, for me it's fine we can merge ;)

@DEKHTIARJonathan DEKHTIARJonathan self-requested a review June 17, 2018 11:22
@DEKHTIARJonathan
Copy link
Member

DEKHTIARJonathan commented Jun 17, 2018 •
edited
Loading

@zsdonghao @lgarithm @luomai do you think we should release version "1.9.1" due to this bug ?
If this makes the library impossible to use on MacOS, maybe it's a good idea to release a bug fix ...

Not sure about this ;)

@tensorlayer tensorlayer deleted a comment Jun 17, 2018
@tensorlayer tensorlayer deleted a comment Jun 17, 2018
@lgarithm
Copy link
Member Author

@DEKHTIARJonathan I tested it on mac, it's working. Thanks for the fix!

@lgarithm lgarithm merged commit 918df45 into master Jun 17, 2018
@lgarithm lgarithm deleted the fix branch June 17, 2018 14:13
@zsdonghao
Copy link
Member

@DEKHTIARJonathan how about 1.9.1rc0 ?

@DEKHTIARJonathan
Copy link
Member

the point of an RC release is to check that everything works as expected without any bug. if we just add a bug fix. we dont need an rc release in my opinion

luomai pushed a commit that referenced this pull request Nov 21, 2018
@lgarithm
matplotlib.use('TkAgg') (#705)
aa3c5f1 
* matplotlib.use('TkAgg')

* update Changelog

* yapf -i tensorlayer/files/utils.py

* only do matplotlib.use('TkAgg') on OSX

* Update utils.py

* remove tailing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luomai luomai luomai approved these changes

@DEKHTIARJonathan DEKHTIARJonathan DEKHTIARJonathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgarithm @DEKHTIARJonathan @zsdonghao @luomai