add pkgconfig feature - make static builds possible #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for this nice crate, does exactly what I need in my project where I need to deal with bad/broken xmls from a legacy software.
I often use the musl target in my projects so the binary can be easy moved across different linux OS-es so I add in this PR a option to build tidy into tidy-sys static. To keep the old option I add a feature
pkg-config
with enables linking against the system library. Took some inspiration from the zstd crate. If you wish to keep the old default I can do that, just addingpkg-config
to default features.BTW did you consider publishing it on crates.io? I know this a "pet" project but I saw far worse pet projects on crates.io :D, in my use case this was a god bless :).