Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECRQM returns crap #1752

Closed
pjanx opened this issue Sep 12, 2020 · 2 comments
Closed

DECRQM returns crap #1752

pjanx opened this issue Sep 12, 2020 · 2 comments

Comments

@pjanx
Copy link

pjanx commented Sep 12, 2020

Problem description

DECRQM is implemented wrong. It reports "set" when the feature is unknown, and reports "unknown" when a feature is known.

                                int internalBit = mapDecSetBitToInternalBit(mode);
                                if (internalBit == -1) {
                                    value = isDecsetInternalBitSet(internalBit) ? 1 : 2; // 1=set, 2=reset.

The fix appears to be trivial: change == to !=.

Additional information

  • Termux application version: master
  • Android OS version: —
  • Device model: —
Grimler91 added a commit that referenced this issue Sep 12, 2020
@Grimler91
Copy link
Member

Thanks for noticing, this bug has apparently been there since the first commit:

@ghost
Copy link

ghost commented Sep 27, 2020

Part of v0.100 release.

@ghost ghost locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants