Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android.permission.READ_LOGS #1821

Closed
henrik-lindqvist opened this issue Nov 17, 2020 · 5 comments
Closed

Add android.permission.READ_LOGS #1821

henrik-lindqvist opened this issue Nov 17, 2020 · 5 comments

Comments

@henrik-lindqvist
Copy link

Please add <uses-permission android:name="android.permission.READ_LOGS" /> to the AndroidManifest.xml. It's a "development" permission which can be granted to via ADB, no root required, so the logcat command can print messages logged from all processes.

@Grimler91
Copy link
Member

Duplicate of #873

@Grimler91 Grimler91 marked this as a duplicate of #873 Nov 17, 2020
@henrik-lindqvist
Copy link
Author

Sorry, couldn't find the posts. I don't want to revive the old threads, why was the previous requests denied?

@xeffyr seem to think it doesn't work for regular apps, but it does since its a "development" permission, and ADB is only required once, to grant it. A few extra bytes of binary XML for a tag in the AndroidManifest.xml is hardly "bloated code", Termux already include 8 of them.

Sad, now i'll have to resort to some (shady) logcat reader app instead, or spend hours building Termux.

@Grimler91
Copy link
Member

I am open for re-visiting the decision.

The permission is not strictly required for anything in termux-app/termux-api, and is only useful if the user runs an adb command, it feels a bit shady to add it as it is not clear what it is needed for. User still needs to find out that they need to run the adb command before it is useful.

If we document it clearly then maybe it is okay.

@xeffyr what do you think?

@ghost
Copy link

ghost commented Nov 17, 2020

@Grimler91 As Termux now is updated on F-Droid only, I'm okay with adding permissions.

May add it today as well as update bootstraps and release Termux v0.103.

ghost pushed a commit that referenced this issue Nov 17, 2020
@henrik-lindqvist
Copy link
Author

@Grimler91 If uninformed, every permission could be seen as "shady". The "development" permissions are more secure since they can only be granted via ADB or as root, and not at run-time like other permissions.

@xeffyr Great! FYI, the Google Play Store has no issue with "development" permissions, my app has included them for years.

@ghost ghost locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants