feat: Allow security group rules to reference the security group created by the module #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the security group created by this module, allow rules to reference this security group itself as the source, in a manner similar to the
self = true
argument for the olderaws_security_group_rule
resource type.This is done by introducing the special value "self" for the
referenced_security_group_id
of the SG rule resource. When this value is used, thenreferenced_security_group_id
receives as a value the ID of the security group created by this module.Motivation and Context
aws_vpc_security_group_ingress_rule
and its egress companion do not have aself
argument. This is reflected in the way this module is written.For clusters in general, it is a good idea to allow intra-cluster communication by default, for reasons such as replication, etc.
We have "self" type rules for the SGs of all clusters.
Breaking Changes
None.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request