Skip to content

feat: Allow security group rules to reference the security group created by the module #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

feat: Allow security group rules to reference the security group created by the module #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8e90e2
allow SG rules to reference self SG
FlorinAndrei Sep 19, 2025
5afa22e
add example for the "self" rule
FlorinAndrei Sep 19, 2025
a5ccd27
remove VPC block from example
FlorinAndrei Sep 19, 2025
b4e363a
fix: Execute `pre-commit run -a`
bryantbiggs Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.99.5
rev: v1.100.0
hooks:
- id: terraform_fmt
- id: terraform_docs
Expand All @@ -23,7 +23,7 @@ repos:
- '--args=--only=terraform_workspace_remote'
- id: terraform_validate
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
rev: v6.0.0
hooks:
- id: check-merge-conflict
- id: end-of-file-fixer
Expand Down
9 changes: 4 additions & 5 deletions examples/redis-cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ module "elasticache" {
# Security Group
vpc_id = module.vpc.vpc_id
security_group_rules = {
ingress_vpc = {
# Default type is `ingress`
# Default port is based on the default engine port
description = "VPC traffic"
cidr_ipv4 = module.vpc.vpc_cidr_block
ingress-self-redis = {
type = "ingress"
referenced_security_group_id = "self"
description = "Allow traffic from this security group to itself."
}
}

Expand Down
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ resource "aws_vpc_security_group_ingress_rule" "this" {
description = try(each.value.description, null)
from_port = try(each.value.from_port, local.port)
prefix_list_id = lookup(each.value, "prefix_list_id", null)
referenced_security_group_id = lookup(each.value, "referenced_security_group_id", null)
referenced_security_group_id = lookup(each.value, "referenced_security_group_id", null) == "self" ? aws_security_group.this[0].id : lookup(each.value, "referenced_security_group_id", null)
to_port = try(each.value.to_port, local.port)

tags = merge(local.tags, var.security_group_tags, try(each.value.tags, {}))
Expand All @@ -349,7 +349,7 @@ resource "aws_vpc_security_group_egress_rule" "this" {
description = try(each.value.description, null)
from_port = try(each.value.from_port, null)
prefix_list_id = lookup(each.value, "prefix_list_id", null)
referenced_security_group_id = lookup(each.value, "referenced_security_group_id", null)
referenced_security_group_id = lookup(each.value, "referenced_security_group_id", null) == "self" ? aws_security_group.this[0].id : lookup(each.value, "referenced_security_group_id", null)
to_port = try(each.value.to_port, null)

tags = merge(local.tags, var.security_group_tags, try(each.value.tags, {}))
Expand Down