-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write last time node of each cycle rather than EOC to database #1090
Conversation
EDIT: |
closed in favor of #1100 |
I can't wait! We will want unit tests on this new feature at some point. Should be straight forward. |
Can we add a release note under "API Changes"? Lines 20 to 22 in b3986c1
I would like it to say that we added a new time node, and slightly modified the meaning of one that existed. (Even if the change is small, this is the place where we tell people it happened.) |
@onufer Can you re-run |
When this PR is ready for final review, you can take it out of "Draft". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark. This change was less painful to make than I expected.
Sorry, last question -- Is there really not any documentation that needs to be updated with this change? |
Well, as I noted somewhere (here or in the ticket?) there is no place in the docs where we explain the time steps in the DB. I imagine that should go some where in It's certainly a strange omission, but I think that needs to be fixed outside this PR. It does need to be fixed though. |
Description
This PR Removes the
interactEOC
database write and forces the write at the last time step instead. The figure below shows the before and after. State points at red lines are written to database. State points with a circle around them are all at the same exact time in the reactor life (within the armi model). The bottom half is the new direction that this PR follows.Note: After this PR, most databases will have 1 more time node, such that there is at least one accessible node for every time in the
Reactor
.Close #1100
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.