Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable index page #823

Merged
merged 8 commits into from
May 28, 2021
Merged

Configurable index page #823

merged 8 commits into from
May 28, 2021

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented May 27, 2021

Description

This makes the path for the index.html template configurable for custom (shogun-boot) applications via an indexTemplate entry in the webpack.config.js. An example entry could look like:

{
  
  indexTemplate: '../my-project-client/resources/index.html',
  
}

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

@dnlkoch dnlkoch changed the title WIP Configurable index page Configurable index page May 27, 2021
Copy link
Member

@annarieger annarieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and surely useful! Thanks!

@dnlkoch
Copy link
Member Author

dnlkoch commented May 28, 2021

Thanks for the reviews!

@dnlkoch dnlkoch merged commit 8492560 into master May 28, 2021
@dnlkoch dnlkoch deleted the configurable-index-page branch May 28, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants