Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding of custom params to print job #830

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Allow adding of custom params to print job #830

merged 2 commits into from
Jul 13, 2021

Conversation

weskamm
Copy link
Member

@weskamm weskamm commented Jul 13, 2021

Description

This allows one to add custom params to the print job by supplying them via the config property.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

dnlkoch
dnlkoch approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine, but please also add the new feature to the CHANGELOG.

@weskamm
Copy link
Member Author

weskamm commented Jul 13, 2021

Changes are fine, but please also add the new feature to the CHANGELOG.

Is there a reason why we do not use an automated approach / commit messages?

@dnlkoch
Copy link
Member

dnlkoch commented Jul 13, 2021

No, there isn't and it would be nice to integrate semantic-release.

@weskamm
Copy link
Member Author

weskamm commented Jul 13, 2021

Allright, thanks for review!

@weskamm weskamm merged commit bd31f3e into master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlkoch dnlkoch dnlkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weskamm @dnlkoch