Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: update display color of all occurences of tessel.name. #1228

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Jun 5, 2017

Signed-off-by: Rick Waldron waldron.rick@gmail.com

@rwaldron
Copy link
Contributor Author

rwaldron commented Jun 5, 2017

It's impossible to stub any of the functions on colors object, as they are all defined as getter accessors, with configurable set to false.

{ get: [Function: get],
  set: undefined,
  enumerable: false,
  configurable: false }

After this patch, I want to eliminate colors and use chalk instead.

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 78.475% when pulling 1c9d9de on update-tessel-name into 3a4280c on master.

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 78.475% when pulling 0a27208 on update-tessel-name into 3a4280c on master.

Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for chalk

@rwaldron rwaldron merged commit d2f7f71 into master Jun 6, 2017
@Frijol Frijol deleted the update-tessel-name branch July 7, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants