Skip to content

Fixed shared_ptr type selection in createSharedInstance #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

johnwason
Copy link
Contributor

The return type switch to std::shared_ptr to boost::shared_ptr happened in boost 1.88.0. This adds a few more condition checks to correct the type selection.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (288bf38) to head (4e95cc5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files           2        2           
  Lines         182      182           
=======================================
  Hits          179      179           
  Misses          3        3           
Files with missing lines Coverage Δ
include/boost_plugin_loader/plugin_loader.hpp 99.05% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnwason johnwason marked this pull request as ready for review July 7, 2025 21:41
@johnwason
Copy link
Contributor Author

@Levi-Armstrong fixed noble build as mentioned in #26

@Levi-Armstrong Levi-Armstrong merged commit 2119f0a into tesseract-robotics:main Jul 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants