Skip to content

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Jun 23, 2022

Various updates per commit messages

  • Replaced header guards with #pragma once for simplicity and to ensure conflict avoidance
  • Updated README to reflect getSection base class requirement
  • Updated example
    • Hide getSection from the public API of the example plugins
    • Return strings rather than references
    • Install the example so it can be run
  • Removed include of plugin_loader.hpp in plugin_loader.h to reduce build times and allow for correct explicit template instantiation

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3 (b8ec58f) into main (46ac798) will not change coverage.
The diff coverage is n/a.

❗ Current head b8ec58f differs from pull request most recent head 0b9590c. Consider uploading reports for the commit 0b9590c to get more accurate results

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          144       144           
=========================================
  Hits           144       144           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Levi-Armstrong
Copy link
Contributor

I am particularly not a fan of using #pragma once mainly because it is not part of the standard. Each are error prone, but I think it is better to stick with something that is part of the standard versus something that is not.

@Levi-Armstrong
Copy link
Contributor

Levi-Armstrong commented Jun 23, 2022

It is also recommended against using #pragma once in the cpp core guidelines.

@Levi-Armstrong
Copy link
Contributor

If it was part of the standard I would definitely use it over the include guards.

@marip8 marip8 merged commit 138acaa into tesseract-robotics:main Jun 23, 2022
@marip8 marip8 deleted the updates branch June 23, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants