-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to provide calibration information in the SRDF #703
Conversation
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 92.16% 90.94% -1.22%
==========================================
Files 173 189 +16
Lines 11097 12628 +1531
==========================================
+ Hits 10227 11484 +1257
- Misses 870 1144 +274
|
8295b7e
to
efd44ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Are you updating the docs too? It looks like you can specify either a file in the urdf or include the information directly in the SRDF? Is there an easy way to load this after the fact if you have to pull it from somewhere?
CalibrationInfo() = default; | ||
|
||
/** @brief The joint origin calibration information */ | ||
tesseract_common::TransformMap joints; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get more documentation on what this does? Does it replace the existing map or get applied on top of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every entry it applies a ChangeJointOriginCommand
, so it is replacing the origin of the joint with what was provided.
Yep, see this PR
You can only provide it in the SRDF. The URDF does have a calibration tag but it is currently not supported. I never looked into how this information is used.
Not exactly. I could create its own command. It currently just loops over the map and applies a ChangeJointOriginCommand for each entry. |
efd44ec
to
414be93
Compare
The current calibration config support defining a joint origin in a yaml config file which gets loaded through the srdf. In the environment it will apply these as a
ChangeJointOriginCommand
.srdf element: