Multiple Updates to WinRM Transport #8
Conversation
smurawski
force-pushed
the
smurawski/fix_com_unpacking
branch
from
dfbccfa
to
461be9a
Compare
smurawski
force-pushed
the
smurawski/fix_com_unpacking
branch
from
bb782c5
to
60aa140
Compare
Collapsed a few common commands to their aliases to save characters. Really needs that trailing line break More tests for powershell functions. System.Security.Cryptography.MD5CryptoService is IDisposable, but has no public Dispose method in .NET 2.0
smurawski
force-pushed
the
smurawski/fix_com_unpacking
branch
from
41dc8ff
to
2b249f2
Compare
smurawski
changed the title
Handle powershell errors: * when powershell script is too long (too many lines or chars?), raise error. * when running powershell script with WinRM fails with exitcode == 0 but its stderr is not empty, raise error. * parse WinRM::Output.stderr, which is CLIXML, into String (error messages parsed from CLIXML).
|
@tyler-ball @fnichol These are some pretty necessary updates. I broke COM uploading when I fixed IO.Compression last time. I've got that sorted out and added a bunch of tests around the PowerShell to cover those cases. I've also got the single file copy fail fixed and a test to cover that. |
|
This LGTM, but I could use some help groking the Powershell - @jdmundrawala |
|
@smurawski this fixes the issue i was having |
| @@ -252,8 +252,8 @@ def decode_files(files) | |||
| vars = %{$hash_file = "#{hash_file}"\n} | |||
|
|
|||
| output = service.run_powershell_script( | |||
| [vars, | |||
| ". #{decode_files_script}", | |||
| ["#{decode_files_script}", | |||
There was a problem hiding this comment.
For my own learning, what does this change do
|
💯 please 🚢 |
|
@jdmundrawala moving the decode-files call out of the script file makes it easier to test the powershell. Then the script file is just a library of functions and we don't have to try to intercept the invocation to test the internal functions. |
|
We have 2 👍 - I'm going to merge this unless someone stops me |
|
merge |
|
I'm seeing pretty decisive |
, so yay!
Multiple Updates to WinRM Transport
Fix unzipping from COM. Closes #7
Fix failed single file copies (when parent directory was not present).
Adding more tests around decode_files.ps1
Cleaner error output from @xmik