Skip to content

feat: Support Elasticsearch 9.x #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

feat: Support Elasticsearch 9.x #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/elasticsearch/testcontainers/elasticsearch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _environment_by_version(version: int) -> dict[str, str]:
return {"discovery.zen.minimum_master_nodes": "1"}
elif version == 7:
return {}
elif version == 8:
elif version in {8, 9}:
# Elasticsearch uses https now by default. However, our readiness
# check uses http, which does not work. Hence we disable security
# which should not be an issue for our context
Expand Down
2 changes: 1 addition & 1 deletion modules/elasticsearch/tests/test_elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


# The versions below should reflect the latest stable releases
@pytest.mark.parametrize("version", ["7.17.18", "8.12.2"])
@pytest.mark.parametrize("version", ["7.17.18", "8.12.2", "9.1.4"])
def test_docker_run_elasticsearch(version):
with ElasticSearchContainer(f"elasticsearch:{version}", mem_limit="3G") as es:
resp = urllib.request.urlopen(es.get_url())
Expand Down