Skip to content

fix: issue #889 by changing the annotated return type of waiting_for to Self. #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+1 −1
Merged

fix: issue #889 by changing the annotated return type of waiting_for to Self. #890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/testcontainers/core/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def maybe_emulate_amd64(self) -> Self:
return self.with_kwargs(platform="linux/amd64")
return self

def waiting_for(self, strategy: WaitStrategy) -> "DockerContainer":
def waiting_for(self, strategy: WaitStrategy) -> Self:
"""Set a wait strategy to be used after container start."""
self._wait_strategy = strategy
return self
Expand Down