Skip to content

Conversation

rafaelss95
Copy link
Contributor

Closes #157.

PS: After opening the issue #157, I noticed that there's an open issue related to this in angular repo: angular/angular#12313.

@timdeschryver timdeschryver merged commit a53db0d into testing-library:master Nov 5, 2020
@rafaelss95 rafaelss95 deleted the fix-157 branch November 5, 2020 18:00
@timdeschryver
Copy link
Member

@all-contributors please add @rafaelss95 for code, tests, bug

Do you think this detectChanges should be exposed?
Similar to spectator's detectComponentChanges

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @rafaelss95! 🎉

@github-actions
Copy link

github-actions bot commented Nov 5, 2020

🎉 This PR is included in version 10.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rafaelss95
Copy link
Contributor Author

Do you think this detectChanges should be exposed?
Similar to spectator's detectComponentChanges

Hmm, not sure about this. What would be the case for its use?

@timdeschryver
Copy link
Member

So devs could use this method.
In 95% of the cases, this wouldn't be needed.... but it's there for when it's needed.
If I see issues around this (if devs want to detect changes manually), I'll probably expose the method but not for now because I see it as a bad practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of rerender with OnPush ChangeDetection
2 participants