Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload to rerender to keep existing Input values when not provided #411

Closed
timdeschryver opened this issue Aug 19, 2023 · 0 comments · Fixed by #427
Closed

Overload to rerender to keep existing Input values when not provided #411

timdeschryver opened this issue Aug 19, 2023 · 0 comments · Fixed by #427

Comments

@timdeschryver
Copy link
Member

timdeschryver commented Aug 19, 2023 •
edited
Loading

This is coming from #365 (comment)

It raises the question if rerender needs to clear the values of input properties that are not provided.
I think it should (similar APIs with other Testing Libraries), but based on the comments I think it would be nice to have an overload to alter this behavior. While helps with the transition to the new version, I think it also helps to improve the DX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add partialUpdate to rerender testing-library/angular-testing-library
1 participant
@timdeschryver