-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add element type generic argument to queries #1023
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bace52:
|
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 916 916
Branches 286 286
=========================================
Hits 916 916
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@all-contributors add @dfoverdx for code |
I've put up a pull request to add @dfoverdx! 🎉 |
🎉 This PR is included in version 8.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Adding generic return types to queries
Closes #615
Why:
It's frustrating doing
wrapper.getByText('...') as HTMLAnchorElement
everywhere just so I can access thehref
propertyHow: By altering the queries declaration file to allow specifying the type when calling the the query function.
Checklist:
docs site
This change is 100% backwards compatible.