Skip to content

Fix UMD export #251

@kentcdodds

Description

@kentcdodds

Right now the UMD export isn't including all the source files 😬

https://unpkg.com/dom-testing-library@3.19.3/dist/dom-testing-library.umd.js

It's treating all the source files as "external" which is not good.

I'm not sure why this is happening, but if someone wants to dive in and figure it out that'd be great.

Looks like it started happening when v3.17.0 was published. The only commit in that version was: 1727a49

I'm 99% positive the reason this happened is because this commit updated kcd-scripts from 0.46.0 to 1.1.0. Here's the diff for that: kentcdodds/kcd-scripts@v0.46.0...v1.1.0 (9 commits).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions