feat(queryBySelectText): add get/query by select text #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Sep 19, 2018
sompylasar
reviewed
Sep 19, 2018
| <select> | ||
| <option value="">Japanese cars</option> | ||
| <option value="volvo">Toyota</option> | ||
| <option value="audi">Honda</option> |
There was a problem hiding this comment.
Fun: Choose a BMW or a Toyota, get a Volvo. Choose a Honda, get an Audi. 😁
There was a problem hiding this comment.
Whoops! Changed these values around and forgot to update the text. 😅
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add methods to access a
<select>element by its selected option's text value.Why:
The first
<option>is commonly used in<select>elements, like a placeholder attribute is used for text inputs. What the user sees is the text value of the first option, but it's not possible to access the<select>element given that text value. This PR provides methods to access the<select>element in that situation. Closes #104.How:
queryBySelectText(),queryAllBySelectText(),getBySelectText(), andgetAllBySelectText()were implemented.Checklist:
Thank you for making an excellent testing library. Happy to be contributing! 😄