feat(labels): add support for aria-labelledby #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 185 192 +7
Branches 51 52 +1
=====================================
+ Hits 185 192 +7
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Oct 10, 2018
alexkrolick
force-pushed
the
aria-labels
branch
from
d4f28ac to
1f58670
Compare
alexkrolick
force-pushed
the
aria-labels
branch
from
1f58670 to
6c8bccd
Compare
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@alexkrolick Thank you very much for implementing this. I just used this feature in one of my tests today! I would have had to use a data-testid otherwise, but this actually forced my app to be more accessible so that awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
What:
Why:
How:
Checklist: