fix: unsafe attribute reference #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need a test to cover this case :) |
|
repro: https://codepen.io/anon/pen/bmYmPd?editors=0011 |
alexkrolick
force-pushed
the
fix-window-ref
branch
from
1565e4f to
0896ee7
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 211 211
Branches 53 54 +1
=====================================
Hits 211 211
Continue to review full report at Codecov.
|
|
@kentcdodds added test |
|
🎉 This PR is included in version 3.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unsafe reference that can throw an error in
debugDOMwhen it receives a reference to adocumentin a real browser (ie puppeteer/codepen)What:
Why:
How:
Checklist: