Skip to content

Conversation

DylanPiercey
Copy link
Contributor

What:

Currently looks like the getNodeText helper is only tested indirectly.

How:

I created a new test file for getNodeText with the expected behavior.

Checklist:

  • Documentation added to the
    docs site N/A
  • Typescript definitions updated "N/A"
  • Tests
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@kentcdodds kentcdodds merged commit 309e507 into testing-library:master Jul 7, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants