Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options type of prettyDOM #309

Merged
merged 1 commit into from Jul 8, 2019
Merged

Conversation

@thomlom
Copy link
Contributor

thomlom commented Jul 8, 2019

What:

Add options type of prettyDOM

Why:

The typings file associated to the prettyDOM functions is outdated and misses the options type.

How:

Checklist:

  • Documentation added to the
    docs site
  • Typescript definitions updated
  • Tests
  • Ready to be merged

I initially opened an issue for the missing documentation on the testing library docs repo: testing-library/testing-library-docs#178

Let me know if I need to update the docs first 馃檪

Copy link
Member

kentcdodds left a comment

Looks good to me!

@kentcdodds kentcdodds merged commit 2846a8e into testing-library:master Jul 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kentcdodds

This comment has been minimized.

Copy link
Member

kentcdodds commented Jul 8, 2019

馃帀 This PR is included in version 5.5.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@kentcdodds

This comment has been minimized.

Copy link
Member

kentcdodds commented Jul 12, 2019

@all-contributors please add @thomlom for code

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Jul 12, 2019

@kentcdodds

I've put up a pull request to add @thomlom! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.