Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix setImmediate issue when using with Cypress. #316

Merged
merged 1 commit into from Jul 12, 2019

Conversation

DylanVann
Copy link
Contributor

@DylanVann DylanVann commented Jul 12, 2019

This is a fix for this issue - #315.

Checklist:

  • Documentation added to the
    docs site N/A
  • Typescript definitions updated N/A
  • Tests N/A? I'm not sure how to test this. I assume it's not caught in @testing-library/cypress because it's tested against an older version.
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

This is fine. Thanks a bunch!

@kentcdodds kentcdodds merged commit f5b84e3 into testing-library:master Jul 12, 2019
1 check was pending
@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Jul 12, 2019

@all-contributors please add @DylanVann for code

@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Jul 12, 2019

@kentcdodds

I've put up a pull request to add @DylanVann! 🎉

setImmediate = setImmediatePolyfill,
} = globalObj
const clearTimeoutFn = globalObj.clearTimeout
const setImmediateFn = globalObj.setImmediate || setImmediatePolyfill
Copy link
Contributor Author

@DylanVann DylanVann Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// istanbul ignore next probably should have gone above this one

Copy link
Member

@kentcdodds kentcdodds Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I should've waited for the build to finish. Could you make that change please?

@kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Jul 12, 2019

🎉 This PR is included in version 5.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants