fix: getByRole error message, when there are no available roles #330
+30
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Jul 31, 2019
src/queries/role.js
Outdated
| roleMessage = ` | ||
| Here are the available roles: | ||
| ${prettyRoles(container) |
There was a problem hiding this comment.
We can avoid calculating the prettyRoles twice by putting roles in here instead of calling prettyRoles(container) again.
There was a problem hiding this comment.
Oops! I meant to do that. Haha.
|
@all-contributors please add @SavePointSam for code and tests |
|
I've put up a pull request to add @SavePointSam! 🎉 |
|
🎉 This PR is included in version 5.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added an error message when there are no available roles.
Why:
Solves #328.
When unable to locate a role, an error message prints listing the available roles. When there are no available roles, the same message would print without a list of roles. This behavior is confusing/misleading to users.
How:
When the length of the string returned by
prettyRolesis 0, we know there are no roles to be listed. The error message then changes based on that condition.Checklist:
docs site N/A