Skip to content

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 25, 2019

What:

Why:

  • Crashes in IE 11 when logging roles

How:

  • Use Object.keys instead

Checklist:

@eps1lon eps1lon added the bug Something isn't working label Sep 25, 2019
@kentcdodds
Copy link
Member

I think it's reasonable to expect that people have a polyfill for this API.

@eps1lon
Copy link
Member Author

eps1lon commented Sep 27, 2019

I think it's reasonable to expect that people have a polyfill for this API.

react itself does not require it and it feels weird to require it because of a testing library.

@eps1lon
Copy link
Member Author

eps1lon commented Sep 27, 2019

We'll just not rely on error throwing in tests. It's brittle anyway.

I still want to emphasize that requiring any polyfill is not viable for component libraries (since this means test under different conditions compared to what the user has) and problematic for application code for the same reasons unless you also include that polyfill in your application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants