Skip to content

Conversation

pheeria
Copy link
Contributor

@pheeria pheeria commented Oct 12, 2019

What:

  • Update http to https
  • Change docs repo links
  • Fix a typo in targetting
  • Align markdown syntax to javascript (there used to be both js and javascript)

Why:

Since GitHub templates are probably the most used documents by various people, I've decided to make small maintenance.

Checklist:

@testing-library testing-library deleted a comment from codesandbox-ci bot Oct 15, 2019
alexkrolick
alexkrolick previously approved these changes Oct 15, 2019
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Just a few comments.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit ca2b250 into testing-library:master Oct 16, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @pheeria for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @pheeria! 🎉

@pheeria pheeria deleted the chore/templates branch October 17, 2019 05:36
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants