-
Notifications
You must be signed in to change notification settings - Fork 468
chore: Add codesandbox ci config #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add codesandbox ci config #383
Conversation
It might be that either only mui-org is whitelisted or it doesn't pick up that @CompuIves Could you take a look or forward this to someone who's working on codesandbox CI? |
I assume it will only run once it is on master (?) |
It will run on PRs. I forgot the e-mail back though. Repositories need to be explicitly whitelisted. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8737c63:
|
This is a really interesting case! So it would make sense if we add an extra option, something like:
so the sandbox adds this dependency as this version? |
@CompuIves Yes. Though you probably meant Or did you mean we need to specify each dependency individually where we want codesandbox to resolve indirect dependencies to the canary? |
Right, with my example it would additionally install |
There wouldn't be one. And even if you would need to build it so that the |
Hmm, I'm not sure if we're talking about the same thing. Is this to make |
/react is depending on /dom. I want codesandbox to resolve /dom to the built version of codesandbox CI. Right now we have two versions when building /dom in codesandbox: the release on npm and the release on codesandboc |
5603c87
to
5d5374b
Compare
Let me know when you're ready for me to merge this. |
@kentcdodds I'm using react-testing-library-examples since I couldn't find another working codesandbox that uses |
This isn't useful at the moment since transitive dependencies of packages on npm are not resolved to the version built in CodeSandbox CI even with |
That's fine |
Now it's working again 😄 Let's merge this and see if it happens again. |
This reverts commit 4b2b463.
Thanks! |
@all-contributors please add @eps1lon for infrastructure |
I've put up a pull request to add @eps1lon! 🎉 |
🎉 This PR is included in version 6.10.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Please don't merge this yet
Testing:
if codesandbox CI runs
how it works with transitive dependencies (the codesandbox from kent only has a direct dependency on
@testing-library/react
but we would like to resolve its dependency on@testing-library/dom
to the canary from this PR as well)Edit: It doesn't at the moment so we use https://github.com/kentcdodds/dom-testing-library-with-anything