Skip to content

Conversation

mmantel
Copy link
Contributor

@mmantel mmantel commented Oct 19, 2019

What:

Fixes a lint error.

Why:

Running npm run validate after pulling a fresh copy of the repo resulted in this error:

[lint] .../dom-testing-library/src/__tests__/element-queries.js
[lint]   372:3  error  Move all hooks before test cases  jest/prefer-hooks-on-top

It appears that it was triggered by this commit in eslint-config-kentcdodds.

How:

Moves an afterEach call to the top of its enclosing block.

Checklist:

  • Documentation added to the
    docs site N/A
  • I've prepared a PR for types targeting
    DefinitelyTyped N/A
  • Tests N/A
  • [x ] Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad4e43f:

Sandbox Source
mystifying-pond-fq50x Configuration

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 7906ad5 into testing-library:master Oct 19, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @mmantel for tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @mmantel! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants