upgrade dom-accessibility-api #489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to release it as 1.x anyway. 0.x semantics aren't helpful right now (API is stable, features should be picked up by |
|
OK, I'll wait for it. Thanks. |
|
When doing #493, I kept getting the following error: [build] [umd.min] [!] Error: 'computeAccessibleName' is not exported by node_modules/dom-accessibility-api/dist/index.js, imported by src/role-helpers.jsSo I kept the |
|
@MichaelDeBoey Let me check this out. Common issue with rollup falsely flagging "not exported from". |
|
#493 will include the update to dom-accessibility-api. Still leaving this at 0.x. Just need to remember to do patch releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Upgraded dom-accessibility-api to ^0.4.1
Why: To support es5 environment. dom-accessibility-api supports es5 from 0.4.1.
PR: eps1lon/dom-accessibility-api#141