fix: queryHelpers.getElementError is not a function #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7fe836d:
|
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 425 426 +1
Branches 101 101
=====================================
+ Hits 425 426 +1
Continue to review full report at Codecov.
|
kentcdodds
previously approved these changes
Mar 30, 2020
|
@all-contributors please add @Yama-Tomo for code and tests |
|
I've put up a pull request to add @Yama-Tomo! 🎉 |
|
🎉 This PR is included in version 7.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If you try to call getElementError in a custom query according to the documentation, you will get an error.
Why:
getElementError was removed in #452.
How:
redefine to queryHelpers
Checklist:
docs site
DefinitelyTyped
NOTE:
I asked a question about this issue. #508
This can be done by require of
@testing-library/dom/dist/config, but I'm wondering if that's the official way to do it (It was a question I wanted to ask on thatissue).Please close this PR if that is official way.
Thanks!