Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/__tests__/role.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,28 @@ Here are the accessible roles:
`)
})

test('does not include the container in the queryable roles', () => {
const {getByRole} = render(`<li />`, {
container: document.createElement('ul'),
})
expect(() => getByRole('list')).toThrowErrorMatchingInlineSnapshot(`
"Unable to find an accessible element with the role "list"

Here are the accessible roles:

listitem:

Name "":
<li />

--------------------------------------------------

<ul>
<li />
</ul>"
`)
})

describe('configuration', () => {
let originalConfig
beforeEach(() => {
Expand Down
9 changes: 6 additions & 3 deletions src/queries/role.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,12 @@ const getMissingError = (
role,
{hidden = getConfig().defaultHidden, name} = {},
) => {
const roles = prettyRoles(container, {
hidden,
includeName: name !== undefined,
let roles = ''
Array.from(container.children).forEach(childElement => {
roles += prettyRoles(childElement, {
hidden,
includeName: name !== undefined,
})
})
let roleMessage

Expand Down