Skip to content

Conversation

nickserv
Copy link
Member

What: Install TypeScript as a development dependency

Why: TypeScript is used implicitly in the typecheck script, but is missing from the dependencies, causing an error when running npm run setup -s as recommended in CONTRIBUTING.md

How: npm i -D typescript

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit feaee79:

Sandbox Source
adoring-snowflake-6q819 Configuration

@kentcdodds kentcdodds merged commit 084b53f into master Jun 12, 2020
@kentcdodds kentcdodds deleted the pr/install-typescript branch June 12, 2020 03:27
@kentcdodds
Copy link
Member

@all-contributors please add @nickmccurdy for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @nickmccurdy! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @nickmccurdy for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @nickmccurdy! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants