docs: add pptr-testing-library link #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Jul 12, 2018
| Implementations include: | ||
|
|
||
| - [`react-testing-library`](https://github.com/kentcdodds/react-testing-library) | ||
| - [`pptr-testing-library`](https://github.com/patrickhulce/pptr-testing-library) |
There was a problem hiding this comment.
vue-testing-library isn't mentioned here even though it is elsewhere in the doc, should it be? Is this not the spot for related projects?
There was a problem hiding this comment.
Definitely should be mentioned!
kentcdodds
approved these changes
Jul 13, 2018
| Implementations include: | ||
|
|
||
| - [`react-testing-library`](https://github.com/kentcdodds/react-testing-library) | ||
| - [`pptr-testing-library`](https://github.com/patrickhulce/pptr-testing-library) |
There was a problem hiding this comment.
Definitely should be mentioned!
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
alexkrolick
added a commit
to alexkrolick/dom-testing-library
that referenced
this pull request
Sep 13, 2018
* chore: issue templates * make headings consistent * use comments * Update Feature_Request.md * Update Question.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds a reference to another implementation of this library for use with puppeteer.
Why:
To have consistent integration test style when using puppeteer.
How:
Inject dom-testing-library into the page and proxy all method requests to it. See https://github.com/patrickhulce/pptr-testing-library :)
Checklist:
Thanks for the library, love it :)