Skip to content

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 10, 2018

What:
Dep upgrade

Why:
I noticed I got both 0.4.0 and 1.0.0 in my lockfile when installing react-testing-library

How:
GitHub UI

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Collaborator

@lgandecki lgandecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Looks like wait-for-element test is flaky (had to rerun the build). I don't know travis well enough to find the failed build now though :/ if that's even possible for an external PR

@SimenB
Copy link
Contributor Author

SimenB commented Sep 10, 2018

If you rerun the build, it's gone, IIRC. You retrigger that specific build, you don't generate a new one

@kentcdodds
Copy link
Member

Are there breaking changes in the library?

@lgandecki
Copy link
Collaborator

Good question. If it works it works by passing the tests, it works - the only change is in the way we export the function (so you no longer have to use .default in some cases).
Since we import (not require) it doesn’t matter.
It is breaking - hence the change of the version, but not in our (dom-testing-library) case.

@kentcdodds
Copy link
Member

Super 👍 thanks friends!

@kentcdodds kentcdodds merged commit 7cb84a9 into testing-library:master Sep 10, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 3.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants