feat: add new rule await-fire-event #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
commented
Oct 1, 2019
Comment on lines
+5
to
+20
| function isAwaited(node) { | ||
| return VALID_PARENTS.includes(node.type); | ||
| } | ||
|
|
||
| function hasThenProperty(node) { | ||
| return node.type === 'MemberExpression' && node.property.name === 'then'; | ||
| } | ||
|
|
||
| function isPromiseResolved(node) { | ||
| const parent = node.parent.parent; | ||
|
|
||
| // fireEvent.click().then(...) | ||
| if (parent.type === 'CallExpression') { | ||
| return hasThenProperty(parent.parent); | ||
| } | ||
| } |
There was a problem hiding this comment.
These methods are partly duplicated, but I prefer to leave them like that for now as they are not exactly the same from await-async-query and see in the future how to refactor them.
thomaslombart
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new rule
await-fire-eventfor waiting special asyncfireEventmethods (only for Vue).