fix: allow console.debug() in no-debug

[gndelia]

closes #327

I intentionally left out the following scenario

const { debug } = console
debug()

because it goes against the first invalid tests that against any debug(), it raises a flag.

[Belco90]

I intentionally left out the following scenario

const { debug } = console
debug()

because it goes against the first invalid tests that against any debug(), it raises a flag.

I'm not sure if I understand the reason. The first invalid case is way too simple but from the Aggressive Reporting point of view is invalid. However, the case you mentioned shouldn't be reported ideally. Am I missing something else?

[gndelia]

I intentionally left out the following scenario

const { debug } = console
debug()

because it goes against the first invalid tests that against any debug(), it raises a flag.

I'm not sure if I understand the reason. The first invalid case is way too simple but from the Aggressive Reporting point of view is invalid. However, the case you mentioned shouldn't be reported ideally. Am I missing something else?

I don't know how I can differentiate

const { debug } = console
debug()

from simply (which is reported from the aggressive reporting point of view)

debug()

as this 👆 is included in the above one

[Belco90]

@gndelia ok, I see what you mean now.

The difference is basically where they come from: one has been declared destructuring from console, the other one hasn't been declared (which is not a real-ish scenario so it should be improved to import it from some module).

Since console is a JS built-in module, we don't need to be that picky checking if the debug method has been declared from a module/object related to Testing Library or not. Just checking that the init.name of the VariableDeclarator (if any) is "console" should be enough to avoid reporting in that case.

Could you include that case in the rule then, please?

[Belco90]

Nice, almost there! Just a couple of small tweaks and this is good to go 🚀

[Belco90]

Awesome 👏

[github-actions]

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀