Skip to content

fix(prefer-query-by-disappearance): fix rule name #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

@MichaelDeBoey MichaelDeBoey added the bug Something isn't working label Jul 18, 2021
@MichaelDeBoey MichaelDeBoey requested a review from Belco90 July 18, 2021 12:02
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

Do we need to regenerate the rules in the README tho?

@MichaelDeBoey
Copy link
Member Author

@Belco90 These aren't used to generate the README list, so it's safe to merge

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's using the filename to generate the README info, not the rule name.

@Belco90 Belco90 enabled auto-merge (squash) July 19, 2021 07:39
@Belco90 Belco90 merged commit 9cf72b2 into main Jul 19, 2021
@Belco90 Belco90 deleted the MichaelDeBoey-patch-1 branch July 19, 2021 07:40
@github-actions
Copy link

🎉 This PR is included in version 4.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants