Wrong link to docs in README #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing .md extension
|
Another one I found: prefer-explicit-assert suggests using it in conjunction with prefer-expect-query-by, which seems not existing. |
Ah we forgot to remove that. Can you address that change too? Thanks! |
Belco90
requested changes
Feb 1, 2020
Belco90
approved these changes
Feb 3, 2020
|
We can address the suggestion for non-existing rule in a different PR. @all-contributors please add @arvigeus for docs |
|
I've put up a pull request to add @arvigeus! 🎉 |
|
I'll remove the rule later today. Thanks! |
|
Don't worry! Addressed already in #78 Thanks for catching this! |
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing .md extension